dotnet/aspnetcore

Add support for binding decimal, double, float data type with configurable formatting

Open

#5,523 opened on May 17, 2018

View on GitHub
 (33 comments) (17 reactions) (1 assignee)C# (10,653 forks)batch import
Pillar: Technical DebtPriority:2affected-mediumarea-blazorenhancementfeature-blazor-component-modelhelp wantedseverity-major

Repository metrics

Stars
 (37,933 stars)
PR merge metrics
 (Avg merge 16d 9h) (258 merged PRs in 30d)

Description

This should work

<input @bind="@price"/>

@code
{
    decimal price;
}

but currently we get an exception: Error: System.ArgumentException: 'bind' does not accept values of type System.Decimal. To read and write this value type, wrap it in a property of type string with suitable getters and setters.

Decimal data type is paramount in every business application. We don't want to use "hacks" and convert it to/from string manually every time.

Support for formatting is also crucial (number of decimal places, decimal and thousandth separators)

Contributor guide

Research direction
Investigate how existing bindings like int and double are implemented in the ASP.NET Core input binding infrastructure. Look for the error source in the ArgumentException thrown. Understand the formatting attributes or mechanisms used for other types.
Tech stack
csharp
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#ASP.NET Core
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45