dotnet/aspnetcore

Url can't be changed for easy reconnect

Open

#5,342 opened on Oct 1, 2018

View on GitHub
 (12 comments) (2 reactions) (0 assignees)C# (10,653 forks)batch import
affected-fewarea-signalrblockedenhancementfeature-client-javafeature-client-javascriptfeature-client-nethelp wantedseverity-minor

Repository metrics

Stars
 (37,933 stars)
PR merge metrics
 (Avg merge 16d 9h) (258 merged PRs in 30d)

Description

Using a client-side cursor (e.g. lastId processed); for a reconnect this wants to be passed back to the server in the query string (as cors doesn't allow custom headers and cors is always applicable to websockets).

However while signalR.HubConnectionBuilder() provides easy construction of the connection; the url cannot be changed after building.

This means if the connection disconnects and you need to pass a cursor (e.g. id); the connection has to be rebuilt and all the events re-registered to the new connection.

It would be easier if the url could be updated and only .start needed to be called again.

Contributor guide

Research direction
Investigate how to add a method to HubConnectionBuilder to allow updating the URL after building, ensuring that the connection can be reconnected with a new URL without re registering events.
Tech stack
csharp
Domain
apibackend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#SignalR
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65