dotnet/aspnetcore

Allow signalr-protocol-msgpack to be use with UMD

Open

#5,336 opened on Sep 14, 2018

View on GitHub
 (8 comments) (0 reactions) (0 assignees)C# (37,933 stars) (10,653 forks)batch import
affected-very-fewarea-signalrenhancementfeature-client-javascripthelp wantedseverity-minor

Description

Could you pls export this module as namespace as well ? (same treatment given to the signalr npm package https://github.com/aspnet/SignalR/issues/951 )

image

Thanks

Contributor guide

Tech stack
javascripttypescript
Domain
frontendbuild system
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
UMD module format basicssignalr protocol msgpack package structureJavaScript build tools
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Review the referenced issue (aspnet/SignalR#951) to understand the UMD export pattern. Examine the build configuration of signalr protocol msgpack, likely in a rollup or webpack config, to add a UMD bundle output. Ensure the exported namespace matches the expected global variable.