dotnet/aspnetcore

Add possibility to inject json reviver function in Typescript client

Open

#5,321 opened on Jul 26, 2018

View on GitHub
 (3 comments) (2 reactions) (0 assignees)C# (10,653 forks)batch import
affected-very-fewapi-suggestionarea-signalrenhancementhelp wantedseverity-minor

Repository metrics

Stars
 (37,933 stars)
PR merge metrics
 (Avg merge 16d 9h) (258 merged PRs in 30d)

Description

Currently there is no possibility to customize in any way the behavior of JsonHubProtocol. It could pass a reviver function to the JSON.parse method. If a user could inject such function to the JsonHubProtocol it would be much easier to perform any data transformation (like converting date strings to Date objects).

Contributor guide

Research direction
Locate the JsonHubProtocol class in the TypeScript client source. Identify where JSON.parse is called and add a configurable reviver parameter. Update the interface and test.
Tech stack
typescript
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
TypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70