Add possibility to inject json reviver function in Typescript client · dotnet/aspnetcore#5321

(3 comments) (2 reactions) (0 assignees)C# (37,933 stars) (10,653 forks)batch import

affected-very-fewapi-suggestionarea-signalrenhancementhelp wantedseverity-minor

Description

Currently there is no possibility to customize in any way the behavior of JsonHubProtocol. It could pass a reviver function to the JSON.parse method. If a user could inject such function to the JsonHubProtocol it would be much easier to perform any data transformation (like converting date strings to Date objects).

Contributor guide

Tech stack: typescriptjavascript
Domain: frontendapi
Issue type: feature
Difficulty: 3
Estimated time: 1-3 hours
Activity status: fresh
Clarity: clear
Prerequisites: TypeScriptJSON
Newbie friendliness: 60
Research direction: Examine the TypeScript client's JsonHubProtocol implementation, likely in the SignalR directory under clients/ts. The goal is to allow users to pass a reviver function to JSON.parse. Start by locating the file that contains the protocol's parse method and understand how JSON is currently deserialized. Then, consider adding an optional reviver parameter to the constructor or parse method, and pass it to JSON.parse. Ensure backward compatibility by making it optional and update the type definitions accordingly. Check existing tests to see how to add test coverage for the new parameter.