dotnet/aspnetcore

Consistent naming standard for private static fields

Open

#50,888 opened on Sep 23, 2023

View on GitHub
 (3 comments) (0 reactions) (1 assignee)C# (10,653 forks)batch import
area-infrastructurehelp wanted

Repository metrics

Stars
 (37,933 stars)
PR merge metrics
 (Avg merge 16d 9h) (258 merged PRs in 30d)

Description

dotnet/aspnetcore mixes _underscore and PascalCase for private static fields. We should pick one for consistency and enable a naming rule to enforce it.

Search results: https://github.com/search?q=repo%3Adotnet%2Faspnetcore%20%22private%20static%20readonly%22&type=code

Note: dotnet/runtime uses s_ prefix.

Contributor guide

Research direction
Review existing naming patterns in the codebase and decide on a consistent prefix for private static fields. Consider aligning with dotnet/runtime's `s ` prefix or choose between ` underscore` and `PascalCase`.
Tech stack
csharp
Domain
backenddeveloper experience
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75