dotnet/aspnetcore

Read additional KestrelServerOptions from config

Open

#4,765 opened on Dec 12, 2017

View on GitHub
 (37 comments) (17 reactions) (0 assignees)C# (10,653 forks)batch import
Needs: Designaffected-fewarea-networkingenhancementfeature-kestrelhelp wantedseverity-minor

Repository metrics

Stars
 (37,933 stars)
PR merge metrics
 (Avg merge 16d 9h) (258 merged PRs in 30d)

Description

The new configuration APIs will read endpoints with their certificates and the default certificate. https://github.com/aspnet/KestrelHttpServer/pull/2186

Here are other KestrelServerOptions to consider reading from config (Unsorted):

  • bool AddServerHeader
  • SchedulingMode ApplicationSchedulingMode
  • KestrelServerLimits Limits
    • long? MaxResponseBufferSize
    • long? MaxRequestBufferSize
    • int MaxRequestLineSize
    • int MaxRequestHeadersTotalSize
    • int MaxRequestHeaderCount
    • long? MaxRequestBodySize
    • TimeSpan KeepAliveTimeout
    • TimeSpan RequestHeadersTimeout
    • long? MaxConcurrentConnections
    • long? MaxConcurrentUpgradedConnections
    • MinDataRate MinRequestBodyDataRate
    • MinDataRate MinResponseDataRate
  • Per Endpoint ListenOptions
  • Per Https Endpoint HttpsConnectionAdapterOptions
    • ClientCertificateMode ClientCertificateMode
    • SslProtocols SslProtocols
    • bool CheckCertificateRevocation
    • TimeSpan HandshakeTimeout

Today these must all be set in code in parallel to the configuration.

Contributor guide

Research direction
Study the existing configuration binding for endpoints (PR #2186) and extend it to include the listed KestrelServerOptions. Focus on KestrelServerOptions, Limits, and ListenOptions properties. Implement configuration binding for each property, ensuring validation and defaults.
Tech stack
csharp
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#ASP.NET Core
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30