dotnet/aspnetcore

Misleading TaskCanceledException

Open

#4,747 opened on May 30, 2018

View on GitHub
 (7 comments) (0 reactions) (0 assignees)C# (10,653 forks)batch import
affected-very-fewarea-networkingbugfeature-kestrelhelp wantedseverity-nice-to-have

Repository metrics

Stars
 (37,933 stars)
PR merge metrics
 (Avg merge 16d 9h) (258 merged PRs in 30d)

Description

I have a WebApi endpoint that parses out the Request.Body itself rather than using Model binding due to performance reasons.

During some requests, I was getting a TaskCanceledException from a TextReader that I never gave any CancellationTokens too. After investigation, I found out that any read operations on the Request.Body after the Request was aborted will throw TaskCanceledExceptions. The stack trace at the time didn't list any Kestrel level code so I spent a lot of time trying to find out how a Stream can possibly cancel a token I never gave it.

This is a bit misleading and should probably change I think.

Contributor guide

Research direction
Investigate the TaskCanceledException thrown when reading request body after the request is aborted. Trace the stack to find where the cancellation token is introduced.
Tech stack
csharp
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
.NETC#
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65