dotnet/aspnetcore

Stop referencing user-replaceable features for internal logic

Open

#4,710 opened on Oct 4, 2018

View on GitHub
 (2 comments) (0 reactions) (0 assignees)C# (10,653 forks)batch import
affected-very-fewarea-networkingenhancementfeature-kestrelhelp wantedseverity-nice-to-have

Repository metrics

Stars
 (37,933 stars)
PR merge metrics
 (Avg merge 16d 9h) (258 merged PRs in 30d)

Description

E.g. the use of RequestHeaders instead of HttpRequestHeaders in the following:

https://github.com/aspnet/KestrelHttpServer/blob/35d35f22a36c9ba564889a355f09d95a8e5b78fe/src/Kestrel.Core/Internal/Http2/Http2MessageBody.cs#L19-L26

Contributor guide

Research direction
Find other references to user replaceable types (e.g., RequestHeaders) in Http2 internal code and replace them with the concrete HttpRequestHeaders.
Tech stack
csharp
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC#
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75