dotnet/aspnetcore

Write more content directly to StreamWriter in W3CLogger

Open

#33,946 opened on Jun 29, 2021

View on GitHub
 (6 comments) (0 reactions) (0 assignees)C# (10,653 forks)batch import
Perfarea-networkinghelp wanted

Repository metrics

Stars
 (37,933 stars)
PR merge metrics
 (Avg merge 16d 9h) (258 merged PRs in 30d)

Description

See https://github.com/dotnet/aspnetcore/pull/33251/#discussion_r655734742, https://github.com/dotnet/aspnetcore/pull/33251/#discussion_r656445769.

https://github.com/dotnet/aspnetcore/blob/3177376dca6ca0a6bba1d4ab946e77f02547c167/src/Middleware/HttpLogging/src/W3CLogger.cs#L49

Since we know the only consumer of this data is StreamWriter, can you delay the Format, enqueue the elements array, and format when writing to the stream? This intermediate string is likely large and useless.

https://github.com/dotnet/aspnetcore/blob/3177376dca6ca0a6bba1d4ab946e77f02547c167/src/Middleware/HttpLogging/src/W3CLoggerProcessor.cs#L35

More content that should be written directly to the streamWriter.

Contributor guide

Research direction
Inspect W3CLogger and W3CLoggerProcessor to identify where intermediate strings are created and modify to write directly to StreamWriter.
Tech stack
csharp
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
C#
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65