dotnet/aspnetcore

Consider using ActivatorUtilities.CreateFactory in AuthenticationHandlerProvider

Open

#2,948 opened on Mar 12, 2018

View on GitHub
 (14 comments) (0 reactions) (0 assignees)C# (10,653 forks)batch import
affected-fewarea-networkingenhancementfeature-http-abstractionshelp wantedseverity-nice-to-have

Repository metrics

Stars
 (37,933 stars)
PR merge metrics
 (Avg merge 16d 9h) (258 merged PRs in 30d)

Description

ActivatorUtilities.CreateInstance is 30x slower than invoking factory delegate.

/cc @Tratcher @HaoK

Contributor guide

Research direction
Examine the current use of ActivatorUtilities.CreateInstance in AuthenticationHandlerProvider and replace it with ActivatorUtilities.CreateFactory to improve performance.
Tech stack
csharp
Domain
backend
Issue type
Performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#Dependency InjectionASP.NET Core
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60