dotnet/aspnetcore

Consider using ActivatorUtilities.CreateFactory in AuthenticationHandlerProvider

Open

#2,948 opened on Mar 12, 2018

View on GitHub
 (14 comments) (0 reactions) (0 assignees)C# (37,933 stars) (10,653 forks)batch import
affected-fewarea-networkingenhancementfeature-http-abstractionshelp wantedseverity-nice-to-have

Description

ActivatorUtilities.CreateInstance is 30x slower than invoking factory delegate.

/cc @Tratcher @HaoK

Contributor guide

Tech stack
csharp
Domain
backend
Issue type
performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C#ASP.NET Coredependency injection
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55
Research direction
Examine the AuthenticationHandlerProvider class in the dotnet/aspnetcore repository. Find the usage of ActivatorUtilities.CreateInstance and replace it with ActivatorUtilities.CreateFactory for performance improvement. Check the linked discussion for any additional context or constraints. Ensure the change maintains backward compatibility.