dotnet/aspnetcore

Review and update form parsing logic

Open

#2,733 opened on Jan 2, 2018

View on GitHub
 (7 comments) (0 reactions) (0 assignees)C# (10,653 forks)batch import
affected-very-fewarea-networkingbugfeature-http-abstractionshelp wantedseverity-nice-to-have

Repository metrics

Stars
 (37,933 stars)
PR merge metrics
 (Avg merge 16d 9h) (258 merged PRs in 30d)

Description

From @Tratcher on Tuesday, August 26, 2014 12:32:12 PM

src/Microsoft.AspNet.WebUtilities/ParsingHelpers.cs has at least one place where it calls char.IsWhiteSpace, but this allows many strange Unicode characters. Review this parsing code and update it to be more accurate.

Copied from original issue: aspnet/HttpAbstractions#119

Contributor guide

Research direction
Examine the ParsingHelpers.cs file for uses of char.IsWhiteSpace and identify the specific Unicode characters that should or should not be considered whitespace. Then propose an update to use a more restrictive check.
Tech stack
csharp
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70