dotnet/aspnetcore

MediaTypeHeaderValue accepts a list of strings instead of a list of StringSegments

Open

#2,695 opened on Jan 2, 2018

View on GitHub
 (13 comments) (0 reactions) (0 assignees)C# (10,653 forks)batch import
affected-very-fewapi-suggestionarea-networkingenhancementfeature-http-abstractionshelp wantedseverity-nice-to-have

Repository metrics

Stars
 (37,933 stars)
PR merge metrics
 (Avg merge 16d 9h) (258 merged PRs in 30d)

Description

Update: API Proposal by @david-acker is in a comment below: https://github.com/dotnet/aspnetcore/issues/2695#issuecomment-1536948278

From @jkotalik on Monday, August 21, 2017 6:09:48 PM

With our efforts to remove usages of strings in favor of string segments, it seems incomplete that MediaTypeHeaderValue.ParseList only accepts a list of strings rather than a list of StringSegment. We should consider adding an overload to accept a list of StringSegment too.

Copied from original issue: aspnet/HttpAbstractions#920

Contributor guide

Research direction
Study the existing MediaTypeHeaderValue.ParseList method and its usage. Create an overload that accepts a list of StringSegments. Refer to the API proposal comment for guidance.
Tech stack
csharp
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC#ASP.NET Core
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65