dotnet/aspnetcore

Add EventSource/EventCounter tracing and metrics for Session

Open

#2,396 opened on Jan 1, 2018

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C# (10,653 forks)batch import
affected-fewarea-middlewareenhancementfeature-sessionhelp wantedseverity-nice-to-have

Repository metrics

Stars
 (37,933 stars)
PR merge metrics
 (Avg merge 16d 9h) (258 merged PRs in 30d)

Description

From @anurse on Wednesday, November 1, 2017 3:22:31 PM

Some events listed below. The goal is to add events that will help users solve problems so if these aren't going to do that job, feel free to suggest/discuss others!

  • Microsoft-AspNetCore-Session EventSource
    • SessionsCreated - Counts sessions created
    • SessionsLoaded - Counts the number of times a session is loaded from the provider (this happens on each request for a session)
    • SessionsCommitted - Counts the number of times a session is commited to the provider (again, happens on each request)
    • We can't track abandoned or timed-out sessions any more as they are handled by caching now and we don't provide a way to explicitly abandon a session. We could detect "empty" sessions (with no data) but such a session could always be added to again later.

See https://gist.github.com/anurse/af1859663ac91c6cf69c820cebe92303 for some guidance on adding EventSources and EventCounters to ASP.NET projects.

Copied from original issue: aspnet/Session#200

Contributor guide

Research direction
Follow the linked guidance to add EventSource events and counters for Session. Implement the listed events: SessionsCreated, SessionsLoaded, SessionsCommitted. Ensure tests are added.
Tech stack
csharp
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
C#.NETEventSource
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70