dotnet/aspnetcore

Add Java client transport fallback

Open

#14,172 opened on Sep 19, 2019

View on GitHub
 (2 comments) (1 reaction) (0 assignees)C# (37,933 stars) (10,653 forks)batch import
affected-mediumarea-signalrenhancementfeature-client-javahelp wantedseverity-minor

Description

We added the LongPolling transport to the Java client in https://github.com/aspnet/AspNetCore/pull/6856

But it currently doesn't do fallback, so the client either connects with the selected transport or it doesn't.

Contributor guide

Tech stack
java
Domain
backendapi
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaSignalR clienttransport fallback logic
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Investigate the Java SignalR client transport implementation, particularly the existing transport classes (LongPolling, WebSockets) and how they are selected. Look at the .NET client transport fallback logic for reference. The main files are likely under 'src/SignalR/clients/java' in the aspnetcore repository. The PR #6856 added LongPolling transport; examine that PR to understand the current state. Consider implementing a fallback mechanism that tries transports in order (e.g., WebSockets first, then LongPolling, then ServerSentEvents) if the first transport fails to connect.
Add Java client transport fallback · dotnet/aspnetcore#14172 | Good First Issue