dotnet/aspnetcore

Detect IIS in-proc from UseKestrel

Open

#13,145 opened on Aug 14, 2019

View on GitHub
 (4 comments) (0 reactions) (0 assignees)C# (10,653 forks)batch import
affected-very-fewarea-networkingenhancementhelp wantedseverity-nice-to-have

Repository metrics

Stars
 (37,933 stars)
PR merge metrics
 (Avg merge 16d 9h) (258 merged PRs in 30d)

Description

Today, if you call UseIIS and UseKestrel, we detect this case and if you're running in-proc we throw. We should consider moving this check in to kestrel itself. The layering isn't the cleanest but it's not a big deal to check if the process name is w3wp in UseKestrel. https://github.com/aspnet/AspNetCore/issues/12944 appears to be a customer getting into this situation.

We should also provide an override option for when you really know that you want to use Kestrel inside w3wp.

Contributor guide

Research direction
Investigate the current IIS in process detection logic in UseIIS and understand how to move the check into UseKestrel. Look at the referenced issue #12944 and the code in aspnetcore repository to determine where the process name check occurs. Consider adding an override option for users who want to force Kestrel inside w3wp.
Tech stack
csharp
Domain
backendweb dev
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#ASP.NET Core
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60