VerifyClosure task is failing if target directory does not exist

Open Beginner friendly
#6,090 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
68/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
csharp
Domain
build-system

Research direction

Open src/Microsoft.DotNet.Build.Tasks.Packaging/src/VerifyClosure.cs around line 388 and inspect how the DGML visualization file is created. Ensure the destination directory exists before the file is written, then verify that VerifyClosure succeeds when the target directory is absent.

Written by the indexing model from the issue text.

Description

help wanted

VerifyClosure task is failing to write the visualization file (DGML) if destination directory does not exist: https://github.com/dotnet/arcade/blob/e11b8486ad155fab13e788a268755c0ca60d3609/src/Microsoft.DotNet.Build.Tasks.Packaging/src/VerifyClosure.cs#L388

The task should ensure that directory exists before trying to create a file, i.e. Directory.CreateDirectory(Path.GetDirectoryName(dependencyGraphFilePath))

Dominant language
C#
Stars
730
Forks
397
Avg merge
2d 9h
Merged PRs (30d)
164

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from dotnet/arcade

All issues in dotnet/arcade

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.