Modernize torchsharp infrastructure

Open
#1,346 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
35/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Stale
Tech stack
csharp
Domain
build-system, ci-cd, release

Research direction

Start with the linked pkg/pack.proj and review the existing YML, local build scripts, CProj, nupkgproj, and SLN setup. Compare the build and packaging structure with the listed Arcade, Microsoft.Build.NoTargets, and dotnet/runtime conventions. Done means the checklist is addressed across the build, project, package, and readme configuration.

Written by the indexing model from the issue text.

Description

In looking at Torchsharp's build I had a few thoughts for improvement.

  • Evaluate using arcade and provided build templates.
  • Remove as much as possible from the YML and have it be part of the local build scripts so that it's easier to repro things that are hit by the official build.
  • Remove use of the nupkgproj and instead pack from the CProj projects where possible
  • For the remaining nupkgproj have them use the Microsf.Build.NoTargets SDK to avoid C# specific targets.
  • Add all projects to the SLN, and control the pack behavior with IsPackable conditions rather than conditions in a project https://github.com/dotnet/TorchSharp/blob/077780db89bfc7671af6262ed817e30cb14cf4d3/pkg/pack.proj#L4
  • Adopt package readme's following a similar convention to dotnet\runtime.
Dominant language
C#
Stars
1.9k
Forks
228
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from dotnet/TorchSharp

All issues in dotnet/TorchSharp

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.