dotnet/EntityFramework.Docs

Clarify that the two statements about additional joins refer to different things

Open

#1,902 opened on Nov 6, 2019

View on GitHub
 (1 comment) (0 reactions) (0 assignees)PowerShell (1,625 stars) (1,961 forks)batch import
area-query-related-datagood first issue

Description

In the section on Including multiple levels it says "This does not mean you will get redundant joins". Then just below the example it says "Since version 3.0.0, each Include will cause an additional JOIN to be added". It's not clear whether the warning only applies where you are including different entities or whether it applies even when you are including the same entity more than once as in the example

Document Details

⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

Contributor guide

Tech stack
csharp
Domain
documentation
Issue type
documentation
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
EF Core basicsMarkdown editing
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
Examine the file entity framework/core/querying/related data.md, specifically the section 'Including multiple levels'. The two statements mentioned need to be compared to understand their different contexts. Review the example below the statement about version 3.0.0. Provide a clarification that distinguishes the warning about redundant joins from the behavior change about additional JOINs.