dotnet/BenchmarkDotNet

BDN does not respect global.json (?)

Open

#2,512 opened on Jan 25, 2024

View on GitHub
 (4 comments) (0 reactions) (0 assignees)C# (11,415 stars) (1,054 forks)batch import
help wantedup-for-grabs

Description

We are using the prerelease of VS (Version 17.9.0 Preview 4.0). Our ennvironment is working with Directory.Build.props which was a problem for a longer time but has been solved recently. Now we wanted to give it another try, but now we are getting a problem with the prerelease. Although are global.json is set to not use prepreleases

{
	"sdk": {
		"allowPrerelease": false
	}
}

We are getting this error:

 MSBuild version 17.9.0-preview-23618-08+82d381eb2 for .NET
C:\Program Files\dotnet\sdk\8.0.200-preview.23624.5\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.RuntimeIdentifierInference.targets(311,5): message NETSDK1057: You are using a preview version of .NET. See: https://aka.ms/dotnet-support-po

According to some other post I updated the nuget source to the current upstream of BDN:

<add key="bdn-ci" value="https://ci.appveyor.com/nuget/benchmarkdotnet" />

Then I get:

MSBuild version 17.8.3+195e7f5a3 for .NET

which is a bit weird because I thought that if things are newer they can work with the newer version. But this is not my problem, the autogenerated project cannot be build.

CSC : error CS0006: Metadata file 'E:\TFS\IPIPE\_Build\obj\ipipe.Core.ArrayMaths.Benchmark\Release\ref\ipipe.Core.ArrayMaths.Benchmark.dll' could not be found [E:\TFS\IPIPE\_Build\Release\Assemblies\ipipe.Core.ArrayMaths.Benchmark\931474bc-6af3-4a5f-b1ed-f4f0043febe1\BenchmarkDotNet.Autogenerated.csproj]

But when go there and build the project manually with dotnet run/build it works.

Is there any suggestion?

Contributor guide

Tech stack
csharp
Domain
performance
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Knowledge of .NET SDK global.jsonBasic C# development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate how BenchmarkDotNet reads global.json and selects the SDK version for building benchmark projects. Check the source code in src/BenchmarkDotNet for any logic that bypasses the global.json settings. Look at the related issue #2512 and any existing PRs. Consider adding a configuration option to respect global.json's allowPrerelease setting.
BDN does not respect global.json (?) · dotnet/BenchmarkDotNet#2512 | Good First Issue