dotansimha/graphql-code-generator

fragment-matcher generated code is wrongly indented

Open

#6600 opened on Sep 1, 2021

View on GitHub
 (1 comment) (0 reactions) (0 assignees)TypeScript (10,341 stars) (1,295 forks)batch import
corehelp wantedstage/1-reproductionstage/2-failing-test

Description

Describe the bug

When using the fragment-matcher plugin against a graphql server this is the result of the generated code. image

To Reproduce Steps to reproduce the behavior: use fragment-matcher plugin. Possibly have not fragments to match.

  1. My GraphQL schema:
# Put your schema here
  1. My GraphQL operations:
# Put your operations here
  1. My codegen.yml config file:
overwrite: true
schema: "http://localhost:3000/graphql"
documents: null
generates:
  src/types/graphql-generated.ts:
    plugins:
      - "typescript"
      - "fragment-matcher"

Contributor guide

Tech stack
typescript
Domain
developer experiencetooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Knowledge of GraphQL code generationBasic TypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Look at the fragment matcher plugin template in the graphql code generator repository (likely in packages/plugins/fragment matcher). Examine the generated code output to identify where indentation is missing. Consider if the issue occurs only when there are no fragments to match. Fix the template to produce correctly indented TypeScript code.