dotansimha/graphql-code-generator

Resolve input types with preResolveTypes same as selection sets

Open

#3,958 opened on Apr 30, 2020

View on GitHub
 (0 comments) (1 reaction) (0 assignees)TypeScript (10,341 stars) (1,295 forks)batch import
corehelp wantedkind/enhancementplugins

Description

Option preResolveTypes should work with input types in the same way as with output types

For example (https://github.com/dotansimha/graphql-code-generator/blob/master/dev-test/star-wars/types.preResolveTypes.ts#L237)

export type CreateReviewForEpisodeMutationVariables = {
   /* ... */
  review: ReviewInput;
};

should be

export type CreateReviewForEpisodeMutationVariables = {
  /* ... */
  review: {
    /** 0-5 stars */
    stars: number;
    /** Comment about the movie, optional */
    commentary?: string;
    /** Favorite color, optional */
    favoriteColor?: Maybe<{
      red: number;
      green: number;
      blue: number;
    }>;
  }
};

Contributor guide

Tech stack
typescriptgraphql
Domain
backenddeveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
GraphQL basicsTypeScriptgraphql code generator plugin development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
The issue requests that the `preResolveTypes` option should also resolve input types inline, similar to how it currently resolves output types. To implement this, examine the existing code that handles `preResolveTypes` for output types in the codebase, likely in the TypeScript plugin package. Look at the dev test file referenced (dev test/star wars/types.preResolveTypes.ts) to see the desired output format. The change likely involves modifying the type resolution logic for input types to match the pattern used for output types. Check the relevant source files, such as plugins/typescript/... or visitor.ts, to understand how types are currently resolved and where to add the input type handling.