dotansimha/graphql-code-generator

Resolve input types with preResolveTypes same as selection sets

Open

#3,958 opened on Apr 30, 2020

View on GitHub
 (0 comments) (1 reaction) (0 assignees)TypeScript (1,295 forks)batch import
corehelp wantedkind/enhancementplugins

Repository metrics

Stars
 (10,341 stars)
PR merge metrics
 (Avg merge 46d 1h) (11 merged PRs in 30d)

Description

Option preResolveTypes should work with input types in the same way as with output types

For example (https://github.com/dotansimha/graphql-code-generator/blob/master/dev-test/star-wars/types.preResolveTypes.ts#L237)

export type CreateReviewForEpisodeMutationVariables = {
   /* ... */
  review: ReviewInput;
};

should be

export type CreateReviewForEpisodeMutationVariables = {
  /* ... */
  review: {
    /** 0-5 stars */
    stars: number;
    /** Comment about the movie, optional */
    commentary?: string;
    /** Favorite color, optional */
    favoriteColor?: Maybe<{
      red: number;
      green: number;
      blue: number;
    }>;
  }
};

Contributor guide

Research direction
Investigate how the preResolveTypes option processes input types in the graphql code generator plugin system. Compare the type resolution logic for input types versus output types, and identify where the inline expansion fails. Look at the plugin's type definitions and the code that generates variables types.
Tech stack
typescriptnodejs
Domain
apibackend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GraphQLTypeScriptNode.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70