dotansimha/graphql-code-generator-community

[Flow] __typename not marked a read-only

Open

#117 opened on Mar 11, 2021

View on GitHub
 (2 comments) (0 reactions) (0 assignees)TypeScript (195 forks)github user discovery
help wanted

Repository metrics

Stars
 (136 stars)
PR merge metrics
 (PR metrics pending)

Description

Describe the bug

To Reproduce Steps to reproduce the behavior:

https://codesandbox.io/s/wizardly-moser-nsrl1?file=/types.js

  1. My GraphQL schema:

Any schema

  1. My GraphQL operations:

No operations.

  1. My codegen.yml config file:
schema: schema.graphql
documents: document.graphql
generates:
  types.js:
    plugins:
      - flow
      - flow-operations
    config:
      useFlowReadOnlyTypes: true

Expected behavior __typename should be read-only

Contributor guide

Research direction
Inspect the Flow plugin templates in graphql code generator to ensure typename is wrapped with `$ReadOnly` when `useFlowReadOnlyTypes: true` is set. Look at how other fields are handled and replicate for typename.
Tech stack
typescriptgraphql
Domain
developer experience
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GraphQLFlow
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65