donnemartin/dev-setup

For all installation scripts, exit immediately if a command exits with a non-zero status

Open

#25 opened on May 29, 2016

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Python (1,162 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (5,984 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

it's important for a script to exit immediately if a command exits with a non-zero status, otherwise results are unpredictable.

this can be achieved by adding set -e at the beginning of all bash scripts

Contributor guide

Research direction
Locate all bash scripts in the repository, add 'set e' at the beginning of each script to ensure immediate exit on non zero status.
Tech stack
shell
Domain
devops
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85