donnemartin/dev-setup

For all installation scripts, exit immediately if a command exits with a non-zero status

Open

#25 opened on May 29, 2016

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Python (5,984 stars) (1,162 forks)batch import
enhancementhelp wanted

Description

it's important for a script to exit immediately if a command exits with a non-zero status, otherwise results are unpredictable.

this can be achieved by adding set -e at the beginning of all bash scripts

Contributor guide

Tech stack
shell
Domain
devopsdeveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic bash scriptingfamiliarity with git workflow
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90
Research direction
The issue requests adding `set e` to all bash scripts in the repository to ensure they exit on errors. To implement, locate all `.sh` files in the repo (e.g., using `find . name "*.sh"`), then add `set e` at the top of each script after the shebang line. Verify changes by running a few scripts to ensure they behave correctly on failure. The repo is https://github.com/donnemartin/dev setup, and the scripts are likely in the root or a scripts directory.