The CLI should warn if passed invalid arguments
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 35/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Stale
- Tech stack
- javascript, node.js
- Domain
- cli
Research direction
The issue concerns command dispatch in donejs-cli, including lookup in node_modules/.bin/ and package.json scripts. Start by reproducing donejs app add some-app and trace how the app command is resolved. Done means invalid commands produce a warning or help output, but the issue notes that work should move to donejs-cli.
Written by the indexing model from the issue text.
Description
@imaustink commented on Mon Sep 18 2017
How often can you reproduce it?
- Always
- Sometimes
- Rarely
- Unable
- I didn’t try
Description:
Running invalid commands exits without any warning. In my opion, this should at least output help.
Steps to reproduce:
Run donejs app add some-app.
Expected results:
The CLI logs a warning or help.
Actual results:
The CLI exits silently.
Environment:
| Software | Version |
|---|---|
| donejs -V | 1.0.1 |
| node -v | 8.4.0 |
| npm -v | 5.3.0 |
| Operating system | Mac OS 10.12.6 |
@matthewp commented on Thu Jan 18 2018
Hey @imaustink, sorry for taking so long to reply. So, what donejs actually does it defer to donejs-cli. donejs-cli will look in node_modules/.bin/ and then package.json's .scripts, for, in this case app. So the fact that it doesn't warn when it finds something is something we can (hopefully) fix in donejs-cli. Going to move this issue there.
- Dominant language
- JavaScript
- Stars
- 6
- Forks
- 7
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from donejs/cli
-
Difficulty 5/5 Over a week Newbie friendliness 15/100
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
-
Override Generators Openenhancement
Difficulty 5/5 Over a week Newbie friendliness 25/100
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
-
discussion question
Difficulty 5/5 Over a week Newbie friendliness 20/100
Similar issues
-
curation good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
amponce/archive-movie-browser#186 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
clerk/javascript#9852 ·
-
bug p1 tools
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
HarperFast/skills#96 ·
-
factory-active factory-automatic task-bug-reproduction-cannot-reproduce task-identify-harness-labels-done task-identify-issue-type-done
Difficulty 2/5 1-3 hours Newbie friendliness 84/100