dogecoin/dogecoin

1.21 Non-SegWit verification

Open

#1,831 opened on Apr 18, 2021

View on GitHub
 (4 comments) (1 reaction) (1 assignee)C++ (2,776 forks)batch import
consensushelp wanted

Repository metrics

Stars
 (14,348 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

As Dogecoin has not enabled SegWit yet, we need to verify how 1.21 works with SegWit. This is not just a transaction format, it also has wide ranging consequences on other elements of node behaviour.

Recommendation is we disable SegWit on RegTest, and then ensure we have an explanation for every test that fails (or unexpectedly passes), followed by introducing per-test overrides as needed and/or correcting behaviour to ensure 1.14 compatibility.

Contributor guide

Research direction
Set up a RegTest environment, disable SegWit, run the full test suite, and document all failing and unexpectedly passing tests. Then, for each test, determine the root cause (e.g., SegWit specific code paths) and decide whether to patch the test or the code.
Tech stack
cpp
Domain
blockchaintesting
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
C++GitBitcoin Core knowledge
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
15