_.isPlainObject seems totally broken

Open
#144 10 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Quiet
Tech stack
javascript
Domain
tooling

Research direction

Start by reproducing the two _.isPlainObject assertions in the issue with Node 0.10 and inspect the _.isPlainObject entry point in underscore-contrib. Compare the observed behavior with the function's intended contract; done means the cause is established and the assertions either pass or the expected behavior is clearly documented.

Written by the indexing model from the issue text.

Description

after modules bug
assert(_.isPlainObject({ a: _.isZero }));
assert(_.isPlainObject({ }));

These fail. I can't find any sane value that will pass. Can someone give me a quick sanity check?

Node 0.10, underscore 1.6

Dominant language
JavaScript
Stars
622
Forks
114
PR merge metrics
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from documentcloud/underscore-contrib

All issues in documentcloud/underscore-contrib

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.