In etcd at least, waitLock() ignores an action

Open
#176 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
go
Domain
distributed-systems

Research direction

Start in store/etcd/etcd.go around waitLock() and the action check near lines 578 and 595. Trace how Delete with a modified index produces compareAndDelete, then verify that Unlock handles that action and add or update a focused test if the existing test structure supports it.

Written by the indexing model from the issue text.

Description

In etcd at least, waitLock(), in checking for an action to send "free" on, does not account for compareAndDelete action which is what results from a Delete with a modified index. Hence, Unlock doesn't often work.

Dominant language
Go
Stars
847
Forks
204
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from docker/libkv

All issues in docker/libkv

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.