Setting http.DefaultClient in store/consul/consul.go causes failure in consul API 0.8.1, Go 1.8.1

Open
#159 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
42/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
go
Domain
distributed-systems

Research direction

Start at store/consul/consul.go line 75 and reproduce the failure with Consul API 0.8.1 under Go 1.8.1. Compare behavior with that line disabled, and verify that consul-api initializes without the nil interface-conversion failure; TLS behavior remains to be checked.

Written by the indexing model from the issue text.

Description

Hello

When working against version 0.8.1 of consul-api under Go 1.8.1, the following line
causes consul-api to fail (interface conversion of nil):
https://github.com/docker/libkv/blob/master/store/consul/consul.go#L75

Commenting this line out lets consul-api proceed with its own default client initialization, which would seem to be enough for the purposes here. (I have't verified that TLS will work, however.)

Dominant language
Go
Stars
847
Forks
204
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from docker/libkv

All issues in docker/libkv

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.