Setting HTTP scheme in store/consul/consul.go overwrites CONSUL_HTTP_SSL

Open
#151 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
45/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
go
Domain
distributed-systems

Research direction

Inspect store/consul/consul.go at line 77 and compare its scheme handling with the Consul API behavior described in the issue. Confirm that CONSUL_HTTP_SSL is no longer overwritten and that HTTPS Consul connections can use the environment variable setting.

Written by the indexing model from the issue text.

Description

Hello!

This line https://github.com/docker/libkv/blob/master/store/consul/consul.go#L77 overwrites the setting that I am trying to pass via the environment variable CONSUL_HTTP_SSL to the hashicorp API. This makes impossible to connect to a consul server with HTTPS, and it is causing an issue in Traefik: https://github.com/containous/traefik/issues/1275.

Fixing the scheme to "https" shouldn't be necessary, as the hashicorp API does it by default (https://github.com/hashicorp/consul/blob/8a5164e14aa5464f807eed493c2fb70329ef2135/api/api.go#L216), so I guess you could remove that line.

Dominant language
Go
Stars
847
Forks
204
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from docker/libkv

All issues in docker/libkv

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.