Use native golang ssh when creating SSH docker client
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 35/100
Research direction
Start in cli/connhelper/connhelper.go at lines 51-65 to understand how the Docker SSH client currently invokes the system ssh binary. Review the linked Go SSH and FIPS documentation, then determine whether native SSH support can replace that invocation while meeting the stated FIPS requirements.
Written by the indexing model from the issue text.
Description
Description
Presently, if configuring a docker client (in golang), docker is using the system ssh binary by executing a crafted command. This happens in connhelper.go https://github.com/docker/cli/blob/master/cli/connhelper/connhelper.go#L51-L65
Golang offers a robust native ssh client directly in the standard library, and works without needing an installation of an OpenSSH client. For security reasons, we prefer to use this ssh client because we can more easily guarantee it will use FIPS validated algorithms without needing to ensure OpenSSH is setup for FIPS correctly.
Golang makes it extremely easy to use FIPS algorithms, especially as of v1.24 where you no longer need to deal with boringcrypto, so moving this to std lib would drastically decrease complexity of Docker setups where we need FIPS SSH and we're using the Docker SDK inside of golang.
If this is not currently possible, would a feature request like this be accepted?
- Dominant language
- Go
- Stars
- 6.1k
- Forks
- 2.2k
- Avg merge
- 1d 15h
- Merged PRs (30d)
- 43
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from docker/cli
-
kind/bug status/0-triage
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
-
kind/feature status/0-triage
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
-
kind/bug status/0-triage
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
kind/bug status/0-triage
Difficulty 2/5 1-3 hours Newbie friendliness 63/100
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
NVIDIA/gpu-operator#2955 ·
-
agentic-workflows
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
kovidgoyal/kitty#10516 ·
-
bug
Difficulty 1/5 Under an hour Newbie friendliness 90/100
cisagov/vulnrichment#337 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 72/100