deprecate config file

Open
#115 0 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Refactor
Clarity
Needs clarification
Activity status
Stale
Tech stack
bash, go
Domain
cli, tooling

Research direction

Start by searching the bashbrew repository for every read of the config file, then compare those paths with the environment-variable usage described in sources.sh. Confirm that no remaining workflow relies on the config file and document the affected entry points before making the deprecation change.

Written by the indexing model from the issue text.

Description

Along with #114, we should deprecate the config file since we mostly just use the environment variables anyway (e.g., https://github.com/docker-library/meta-scripts/blob/da908ae960aaf23ff67b1d465af0ab1b47183fd8/sources.sh#L28).

Environment variables are easy enough to permanently add to things like bashrc (and Jenkins config) that we don't really need the config file (and actively don't consult it in meta scripts anyway because that's increased complexity).

We need to make sure we don't rely on it anywhere (like me locally 🙈😢).

Dominant language
Go
Stars
146
Forks
58
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from docker-library/bashbrew

All issues in docker-library/bashbrew

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.