dmlc/xgboost

Better support for mypy.

Open

#6,496 opened on Dec 13, 2020

View on GitHub
 (20 comments) (3 reactions) (0 assignees)C++ (8,872 forks)batch import
feature-requestgood first issue

Repository metrics

Stars
 (28,376 stars)
PR merge metrics
 (Avg merge 3d 18h) (34 merged PRs in 30d)

Description

Currently many more Python projects like dask and optuna are using Python type hints. With the Python package of xgboost gaining more and more features, we should also adopt mypy as a safe guard against some type errors and for better code documentation.

Contributor guide

Research direction
Add mypy configuration and fix type errors in the Python package.
Tech stack
python
Domain
backendtooling
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Pythonmypy
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60