dmlc/dgl

Build failed on `s390x`(LinuxONE) platfrom

Open

#6,487 opened on Oct 23, 2023

View on GitHub
 (2 comments) (0 reactions) (1 assignee)Python (12,665 stars) (2,928 forks)batch import
bug:unconfirmedhelp wanted

Description

🐛 Bug

I've just tried to run a model built with DGL on an IBM s390x machine (aka LinuxONE), since DGL doesn't provide a official build for this platform, I tried to build myself.

To Reproduce

Steps to reproduce the behavior:

  1. Prepare environment & start building by following https://docs.dgl.ai/install/index.html#install-from-source:
bash script/create_dev_conda_env.sh -c -p 3.10 -o <path/to/yml>
# Manually install dependencies..
bash script/build_dgl.sh -c
  1. Build failed with the following error:
    image
error: ‘Write’ is not a member of ‘dmlc::serializer::UndefinedSerializerFor<dgl::serialize::GraphType>’
   63 |     Else::Write(strm, data);
      |     ~~~~~~~~~~~^~~~~~~~~~~~

Expected behavior

DGL built successfully.

Environment

  • DGL Version (e.g., 1.0): 1.1.2
  • Backend Library & Version (e.g., PyTorch 0.4.1, MXNet/Gluon 1.3):
  • OS (e.g., Linux): Ubuntu 22.04 on s390x
  • How you installed DGL (conda, pip, source): source
  • Build command you used (if compiling from source):
  • Python version: 3.10
  • GPU models and configuration (e.g. V100): none
  • My compiler version:
g++ (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0
Copyright (C) 2021 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Additional context

Since S390X is a big-endian architecture, I wonder if there are any code that doesn't support big-endian exists. Maybe I can workaround it by disabling these components.

Any help would be thanked!

Contributor guide

Tech stack
pythoncpp
Domain
machine learningdata
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
C++ programmingCMake build systemUnderstanding of big endian vs little endianFamiliarity with DGL build process
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
15
Research direction
The build fails on s390x (big endian) due to missing serializer specialization for `dgl::serialize::GraphType` in `dmlc::serializer::UndefinedSerializerFor`. Investigate the serialization code in `dgl/src/serialize/` or `dmlc core/include/dmlc/serializer.h` to add endianness support. Look for existing conditional compilation (`#if BYTE ORDER == BIG ENDIAN`) and consider adding a template specialization or using `dmlc::serializer::BigEndianWrapper`. Also check if there is a way to disable the offending component as a workaround. Review comments from the assignee for progress.