djenriquez/vault-ui

Confirmation of secret change - Feature request

Open

#101 opened on Apr 24, 2017

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (159 forks)batch import
feature requesthelp wanted

Repository metrics

Stars
 (1,306 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

First off, great job! I really appreciate the work. Would it be possible to add a confirmation when changing a secret? It seems too easy to accidentally overwrite a secret. This might be more my use case than others, but I have a lot secrets that just get read and I want to avoid them being inadvertently changed when a user is copy/pasting them.

Two ideas:

  1. Just a simple confirmation box before saving
  2. Have the secrets displayed in a modal, non-editable mode which requires clicking an edit button to make changes.

Contributor guide

Research direction
Locate the secret editing component in the codebase and add a confirmation dialog (e.g., using a modal or window.confirm) before the save action.
Tech stack
javascriptreact
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
React
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80