djenriquez/vault-ui

Confirmation of secret change - Feature request

Open

#101 opened on Apr 24, 2017

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (1,306 stars) (159 forks)batch import
feature requesthelp wanted

Description

First off, great job! I really appreciate the work. Would it be possible to add a confirmation when changing a secret? It seems too easy to accidentally overwrite a secret. This might be more my use case than others, but I have a lot secrets that just get read and I want to avoid them being inadvertently changed when a user is copy/pasting them.

Two ideas:

  1. Just a simple confirmation box before saving
  2. Have the secrets displayed in a modal, non-editable mode which requires clicking an edit button to make changes.

Contributor guide

Tech stack
javascriptreact
Domain
frontendsecurity
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
The feature request proposes adding a confirmation step before saving a secret to prevent accidental overwrites. Two approaches are suggested: a simple confirmation dialog or a modal with an edit button. To implement, examine the current secret creation/editing workflow, likely in a React component such as SecretForm.js or similar. Adding a state variable for editing mode and a confirmation modal component would achieve this. The existing UI patterns for modals in the project can be reused.