fundraising: 'customer.subscription.deleted' webhook event always gets 404 response · django/djangoproject.com#764

(5 comments) (0 reactions) (0 assignees)Python (2,001 stars) (1,100 forks)user submission

bugfundraisinggood first issue

Description

The response to stripe 'customer.subscription.deleted' webhook event is always 404. The reason is:

In the cancel_donation view, stripe_subscription_id is set to an empty string https://github.com/django/djangoproject.com/blob/e5a4bf20fb58c463441c15d552c022b03f716858/fundraising/views.py#L178

In the subscription_cancelled webhook handler method, the donation object is fetched using stripe_subscription_id which was set to an empty string earlier.

https://github.com/django/djangoproject.com/blob/e5a4bf20fb58c463441c15d552c022b03f716858/fundraising/views.py#L232-L233

So, the response will always be 404 and no cancellation email will be sent to the donor.

Contributor guide

Tech stack: python
Domain: backendpayments
Issue type: bug
Difficulty: 3
Estimated time: under 1 hour
Activity status: stale
Clarity: clear
Prerequisites: DjangoStripe APIPython
Newbie friendliness: 70
Research direction: The bug is in fundraising/views.py. In the cancel donation view, stripe subscription id is set to an empty string at line 178. The subscription cancelled webhook handler at lines 232-233 uses that empty id to fetch the donation, resulting in a 404. To fix, ensure the subscription id is retained until after the webhook is processed, or handle the case where the subscription id is cleared. This is a small localized change that a newcomer can implement.