Unused `toggleOffOn` should not disable other checks

Open
#2,776 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
48/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
java
Domain
build-system

Research direction

Start by running gradle spotlessCheck in the linked reproduction and compare the result with and without toggleOffOn in build.gradle.kts at line 19. Inspect the failing Java example at src/main/java/org/example/Main.java line 3; done means the unrelated check still fails when toggleOffOn is unused.

Written by the indexing model from the issue text.

Description

I noticed that unused toggleOffOn is disabling other checks. For example, see https://github.com/apoorva-sriv/spotless-gradle-toggleoffon-issue. gradle spotlessCheck fails correctly without toggleOffOn but passes when it's there, which is incorrect.

Dominant language
Java
Stars
5.7k
Forks
560
Avg merge
1d 13h
Merged PRs (30d)
43

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from diffplug/spotless

All issues in diffplug/spotless

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.