removeUnusedImport check fails when there are pattern matching switch expressions with inner classes

Open
#2,492 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
java
Domain
tooling

Research direction

Start by reproducing the failure from the switch expression in src/main/java/daomephsta/unpick/impl/constantmappers/datadriven/ExpressionEvaluator.java, focusing on the removeUnusedImport check and the reported line 142 error. Trace how this pattern-matching switch is parsed and verify that the check completes without the '.class' expected error.

Written by the indexing model from the issue text.

Description

I have the following switch expression

result = switch (literal) {
	case Literal.Integer(int value, int ignored) -> value;
	case Literal.Long(long value, int ignored) -> value;
	case Literal.Float(float value) -> value;
	case Literal.Double(double value) -> value;
	case Literal.Character(char value) -> value;
	case Literal.String(String value) -> value;
};

and it causes the removeUnusedImport rule to fail with the following message:

  src/main/java/daomephsta/unpick/impl/constantmappers/datadriven/ExpressionEvaluator.java:L142 removeUnusedImports(removeUnusedImports) error: '.class' expected

full code

Dominant language
Java
Stars
5.7k
Forks
560
Avg merge
1d 13h
Merged PRs (30d)
43

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from diffplug/spotless

All issues in diffplug/spotless

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.