Prettier typescript act as tsx instead of ts

Open
#2,479 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
typescript
Domain
build-system, tooling

Research direction

Start with the Gradle typescript configuration in the reproduction and compare it with the explicit format 'typescript' configuration that produces the expected output. Reproduce both cases with the shown generic function and .prettierrc setting, then verify that the predefined format no longer treats TypeScript input as TSX.

Written by the indexing model from the issue text.

Description

I have this code and i saw a difference when running prettier using npm directly and when running using spotless

When using npm the code is formated like this
export const myFunction = <T = string>(

But when using spotless the code change like this
export const myFunction = <T = string,>(

gradle configuration :
typescript { target 'src/**/*.ts' prettier("${prettierVersion}") .npmExecutable("${tasks.named('npmSetup').get().npmDir.get()}${npmExec}") .nodeExecutable("${tasks.named('nodeSetup').get().nodeDir.get()}${nodeExec}") .configFile('.prettierrc') }

npm run format command in package.json :
"format": "prettier --config .prettierrc --ignore-path .prettierignore --write ./src/**",

prettierrc tralingComa defined to "all"

i fixed by changing gradle configuration to this and now spotless format exactly as npm
format 'typescript', { target 'src/**/*.ts' prettier("${prettierVersion}") .npmExecutable("${tasks.named('npmSetup').get().npmDir.get()}${npmExec}") .nodeExecutable("${tasks.named('nodeSetup').get().nodeDir.get()}${nodeExec}") .configFile('.prettierrc') }

I think using predefined typescript format act as tsx format (i don't use tsx, but i saw that tsx require trailing coma in generics).

Dominant language
Java
Stars
5.7k
Forks
560
Avg merge
1d 13h
Merged PRs (30d)
43

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from diffplug/spotless

All issues in diffplug/spotless

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.