git setting of line endings are not fetched from gitconfig file in git home folder

Open
#2,342 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
groovy, java, json, kotlin, markdown, shell, yaml
Domain
build-system

Research direction

Reproduce the issue on Windows 11 with Gradle 8.11 and Spotless 6.25 using the configuration shown, comparing C:\Program Files\Git\etc\gitconfig with $HOME/.gitconfig. Check the Kotlin, Groovy, shell, JSON, YAML, Markdown, and text format targets; done means core.autocrlf from the Git home configuration is honored and files retain the expected LF endings.

Written by the indexing model from the issue text.

Description

bug-unconfirmed
  • summary of problem
    My C:\Program Files\Git\etc\gitconfig file has a [core] autocrlf = input setting but this parameter is not defined in $HOME/.gitconfig.
    kotlin, kotlinGradle, groovy, shell, json, yaml, format("markdown"), format("text") has a problem with LF line ending and fixes to CRLF. Java is not effected.
    If [core] autocrlf = input set in $HOME/.gitconfig, spotless works well.
  • Gradle or Maven version
    Gradle 8.11
  • spotless version
    6.25
  • operating system and version
    Win 11
  • copy-paste your full Spotless configuration block(s), and a link to a public git repo that reproduces the problem if possible
    spotless { java { target("**/*.java") targetExclude(defaultExcludes) googleJavaFormat(libs["google-java-format"].version) .reflowLongStrings() .formatJavadoc(true) targetExclude(defaultExcludes) } kotlin { target("**/*.kt") targetExclude(defaultExcludes) ktfmt(libs["ktfmt"].version).googleStyle() } kotlinGradle { ktfmt(libs["ktfmt"].version).googleStyle() targetExclude(defaultExcludes) } groovy { target("**/*.groovy", "Jenkinsfile", "**/Jenkinsfile.*") targetExclude(defaultExcludes) trimTrailingWhitespace() endWithNewline() } shell { target("**/*.sh", "src/main/sh/**/*") targetExclude(defaultExcludes) localPrettier(libs["prettier"], libs["prettier-sh"]) .config( mapOf( "plugins" to listOf("prettier-plugin-sh"), "parser" to "sh", *prettierDefaults ) ) trimTrailingWhitespace() endWithNewline() } json { target("**/*.json", "**/*.json5") targetExclude(defaultExcludes) localPrettier(libs["prettier"]) .config(mapOf(*prettierDefaults)) } yaml { target("**/*.yaml", "**/*.yml") targetExclude(defaultExcludes) localPrettier(libs["prettier"]) .config(mapOf(*prettierDefaults)) } format("markdown") { target("**/*.md") targetExclude(defaultExcludes) localPrettier(libs["prettier"]) .config(mapOf(*prettierDefaults)) } format("text") { target( "**/.gitattributes", "**/.gitignore", "**/.npmrc", "**/.sdkmanrc", "**/*.properties", "Dockerfile", "**/*.txt", "**/*.config" ) targetExclude(defaultExcludes) trimTrailingWhitespace() endWithNewline() indentWithSpaces(2) } }
Dominant language
Java
Stars
5.7k
Forks
560
Avg merge
1d 13h
Merged PRs (30d)
43

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from diffplug/spotless

All issues in diffplug/spotless

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.