Add JPMS module-info.java
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 25/100
- Issue type
- Feature
- Clarity
- Needs clarification
- Activity status
- Stale
- Domain
- build-system
Research direction
Start by reviewing the feat/module-info branch diff and merging the latest main, then inspect its module-info.java and the fake NeededForModuleInfo.java files in the java folder. Confirm the canonical JPMS metadata with project maintainers or JPMS documentation. Done means selfie supports module-info.java with the required files compiling successfully.
Written by the indexing model from the issue text.
Description
I'm not sure that anyone will ever need this. But I mistakenly thought that we did to reproduce a user bug, so I started experimenting in the feat/module-info branch (see diff).
The hiccups I ran into were:
- the
module-info.javahas to be in ajavafolder, not akotlinfolder - stuff that is in the
javafolder can't reference stuff in thekotlinfolder - we needed fake package-private
NeededForModuleInfo.javafiles in the java folder to avoid compilation errors in themodule-info.java
If you need selfie to support module-info.java, I'm happy to merge a PR that does it, and you can use this as a starting point.
- the hiccups above are fine with me. If you can fix the workarounds great, but I don't mind shipping them
- please merge in from main first, maybe the latest version of the Kotlin plugin will have made it easier by then
- I would like the metadata (naming and whatsuch) to be canonical, and I don't have enough experience with JPMS to know what it should be. Hopefully if you need JPMS, you've also got enough experience that you can set this metadata better than I did.
- Dominant language
- Kotlin
- Stars
- 101
- Forks
- 18
- Avg merge
- 6d 11h
- Merged PRs (30d)
- 5
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from diffplug/selfie
-
Selfie JVM Snapshot Garbage Collection is overly zealous when using multiple test suites in gradle Openbug jvm
Difficulty 4/5 3-5 days Newbie friendliness 48/100
-
enhancement jvm
Difficulty 5/5 Over a week Newbie friendliness 25/100
-
bug jvm
Difficulty 4/5 3-5 days Newbie friendliness 35/100
-
bug docs jvm
Difficulty 2/5 1-3 hours Newbie friendliness 50/100
-
bug jvm py
Difficulty 2/5 1-3 hours Newbie friendliness 48/100
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Telegram !!! Open
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Xposed-Modules-Repo/com.fuck.iab#24 · 3 comments · 1 reaction ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
SimonHalvdansson/Harmonic-HN#361 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
johanhaleby/occurrent#1120 ·