suggested improvements to `com.diffplug.eclipse.apt`

Open

#117 opened on Jan 27, 2020 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty: 4/5
Estimated time: 3-5 days
Newbie friendliness: 35/100

Issue type: Refactor
Clarity: Mostly clear
Activity status: Stale
Tech stack: java
Domain: build-system, tooling

Research direction

Start by reviewing the com.diffplug.eclipse.apt implementation, especially AptSourceSetConvention, AptPlugin52, AptPlugin, and the plugin DSL around getAllCompilerArgs. The intended result is to extract annotation processor arguments from Gradle's compiler options, remove the obsolete components, and preserve annotation processing for Eclipse builds.

Written by the indexing model from the issue text.

Description

enhancement

The com.diffplug.eclipse.apt plugin is just copy-pasted with a few minor fixes from the https://github.com/tbroyer/gradle-apt-plugin, which is no longer maintained. It is no longer maintained because Gradle incorporated native support for annotation processing, so the plugin became extraneous. The one exception is gradle+eclipse, where annotation processing still requires this plugin.

Per advice from the original author, it would be good to remove the plugin DSL and extract annotation processor arguments from getAllCompilerArgs instead; and remove the AptSourceSetConvention, remove/inline AptPlugin52, and remove the AptPlugin altogether.

When/if eclipse.apt generates problems or deprecation warnings in a future release, I'll consider taking this on if it's the easiest way to fix them. So long as the current code works perfectly, it will not make the top of my todo list. If it makes the top of anyone else's todo list, I'll be happy to merge these improvements :)

Dominant language: Java
Stars: 137
Forks: 33
PR merge metrics: No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

Read the whole issue, then the project's contributing guide.
Comment on the issue to say you are picking it up — it saves two people doing the same work.
Fork the repository and make your change on a branch.
Open a pull request that references the issue number.