diesel-rs/diesel

Compilation with `infer_schema!` panics when table has column named `ops`

Open

#851 opened on Apr 6, 2017

View on GitHub
 (5 comments) (0 reactions) (1 assignee)Rust (12,054 stars) (1,003 forks)batch import
assignedbughelp wanted

Description

Somewhere in the macro expansion, there is code that imports ops from within diesel. If a column in a database is named ops, this causes conflicts within the macro.

I think that putting a note somewhere that this could happen may be enough; however, prefixing the internal variables or module names to something like _table_ops or something similar would be a more permanent solution.

Contributor guide

Tech stack
rust
Domain
backenddatabase
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Rust macrosDiesel ORM
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Investigate the `infer schema!` macro implementation in the diesel codebase. The issue arises because the macro imports `ops` from diesel internally, conflicting with a table column named `ops`. A possible fix is to prefix internal variable names like ` table ops` to avoid name conflicts. Key files to look at include the macro definitions in the `diesel` crate.