diegomura/react-pdf

Some borders draw faint pencil-like artefacts

Open

#700 opened on Aug 29, 2019

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (13,687 stars) (1,116 forks)batch import
help wanted

Description

Describe the bug Some borders get slight artefacts at the outer edges and through the corners of the border, which almost look like faint pencil strokes. In the example below, it happens around the dark boxes, but not around the light boxes (at least not visibly so). Zoom in on the generated PDF to see it in action.

To Reproduce Reproduced in this REPL snippet

Expected behavior Those artefacts should not appear.

Screenshots

Desktop:

  • OS: MacOS 10.13.6
  • Browser N/A, but verified in the Preview.app PDF viewer and in Safari and Chrome's PDF viewers.
  • React-pdf version v1.6.4

Contributor guide

Tech stack
reactjavascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ReactJavaScriptPDF rendering concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the border rendering code in react pdf, likely in the styling or layout modules. The issue reproduces in the provided REPL snippet. Start by examining how borders are drawn for elements, particularly those with dark backgrounds. Look for any coordinate rounding or anti aliasing logic that might cause faint lines. Check the underlying pdfkit library if the issue stems from there. Also consider testing with different border widths and colors to isolate the problem.