diegomura/react-pdf

<Image /> throws error when using in NextJS with swcMinify

Open

#2063 opened on Oct 26, 2022

View on GitHub
 (5 comments) (0 reactions) (0 assignees)JavaScript (13,687 stars) (1,116 forks)batch import
help wanted

Description

Describe the bug I'm using react-pdf with nextjs (v12). When running in dev mode everything works as expected. When building the app for production with swcMinfiy: true in next.config.js I'm getting the following error on the component

Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'width')
    at drawImage (_app-4582e1627b46c737.js:115:440420)
    at renderImage (_app-4582e1627b46c737.js:115:440829)
    at renderNode (_app-4582e1627b46c737.js:115:452973)
    at d (_app-4582e1627b46c737.js:115:452461)
    at Array.forEach (<anonymous>)
    at renderChildren (_app-4582e1627b46c737.js:115:452482)
    at renderNode (_app-4582e1627b46c737.js:115:452985)
    at d (_app-4582e1627b46c737.js:115:452461)
    at Array.forEach (<anonymous>)
    at renderChildren (_app-4582e1627b46c737.js:115:452482)

Using swcMinify: false it works as expected. But swc is considered best practice/ stable and is on per default starting Nextjs v13. So leaving it off can't be the solution.

To Reproduce as described above

Expected behavior Should not throw error

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: MacOS M1
  • Browser: Chrome
  • Nextjs v12
  • React v18
  • React-pdf v.3.0.0

Contributor guide

Tech stack
reactnextjsjavascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Familiarity with Next.jsBasic understanding of SWC minification
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate how swcMinify in Next.js affects the rendering of react pdf's Image component. The error occurs during production build with swcMinify enabled. Look at the drawImage and renderImage functions in the react pdf source to see how they handle image dimensions. Check if minification renames or removes properties like 'width'. Consider testing with different minification settings or reproducing the issue in a minimal Next.js project.