diegohaz/schm

Validators are being ignored when type is an array

Open

#37 opened on Jun 6, 2018

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (23 forks)github user discovery
bughelp wanted

Repository metrics

Stars
 (512 stars)
PR merge metrics
 (PR metrics pending)

Description

Reported by @J-F-Liu in https://github.com/diegohaz/schm/issues/35#issuecomment-395087573

schema({
  correctOptions: {
    type: [String],
    minlength: 1,
  },
});

with this code, the minlength validator is ignored.

Contributor guide

Research direction
Inspect the schema validation logic to understand why validators are ignored when type is an array. Look at how the schema processes the `type` field and how validators like `minlength` are applied.
Tech stack
javascript
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70