diegohaz/arc

[redux/entities] API path with child path not handled

Open

#292 opened on Jun 23, 2017

View on GitHub
 (3 comments) (3 reactions) (0 assignees)JavaScript (291 forks)github user discovery
PR welcomeenhancementhelp wanted

Repository metrics

Stars
 (2,924 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

If I dispatch a path like this, then the / will error out my client and not cause it to dispatch.

A schema is expecting the variable name of order/statistics. Can we add handling for special characters like this on the schema entities?

const mapDispatchToProps = (dispatch, { limit }) => ({
  readList: () =>
    dispatch(
      resourceListReadRequest('orders/statistics', { _limit: limit })
    ),
})

Contributor guide

Research direction
Examine the redux entities reducer to see how resource paths are used as keys. Allow special characters like slashes in the path by sanitizing or encoding them, ensuring the dispatch works without errors.
Tech stack
javascriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75