didi/cube-ui

[New Feature] Validate扩展方法和类型能不能增加链式调用

Open

#356 opened on Nov 26, 2018

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (1,503 forks)batch import
help wanted

Repository metrics

Stars
 (9,088 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

What problem does this feature solve?

Validator添加自定义规则时候：

Validator.addRule('odd', (val, config, type) => !config || Number(val) % 2 === 1)
Validator.addMessage('odd', 'Please input odd.')

显得比较蛋疼，最好能链式调用

Validator.addRule('odd', (val, config, type) => !config || Number(val) % 2 === 1)
.addMessage('odd', 'Please input odd.')

显得比较优雅

Contributor guide

Research direction
Modify addRule and addMessage methods to return 'this' for chaining.
Tech stack
javascript
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptVue
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80