diasurgical/devilutionX

[Issue Report]: Full screen option on Nintendo Switch

Open

#7032 opened on Mar 17, 2024

View on GitHub
 (5 comments) (0 reactions) (0 assignees)C++ (7,255 stars) (743 forks)batch import
good first issue

Description

Operating System

Nintendo Switch

DevilutionX version

1.5.2

Describe

I guess the full screen option is meant for desktop versions of the app. On consoles like Nintendo Switch it has no sense, as there's not a desktop. So, enabling it, creates some weird results, depending on the set screen dimension (480p, 720p, 1080p):

SI_1

SI_2

Maybe is it better to remove it in the next releases?

I also noticed other options that seem not useful at all on a console, like the keyboard shortcuts settings (the gamepad one is the only working here).

To Reproduce

Settings > Graphics > Full screen

Expected Behavior

No option at all.

Additional context

No response

Contributor guide

Tech stack
cpp
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
The issue describes a bug on Nintendo Switch where the 'Full screen' option causes rendering issues. To fix, the option should be hidden or disabled for console platforms. The code changes likely involve conditional compilation (e.g., #ifdef) in the settings UI code. Look for files handling graphics options, possibly in Source/diablo.cpp or Source/options.cpp. No linked PRs or maintainer comments are visible in the issue.