diasurgical/devilutionX

Backport Zhar multiplayer fixes from @pionere

Open

#2995 opened on Sep 30, 2021

View on GitHub
 (5 comments) (0 reactions) (0 assignees)C++ (7,255 stars) (743 forks)batch import
good first issuehelp wanted

Description

@pionere appears to have made the Zhar quest work in multiplayer: https://github.com/pionere/devilutionX/commit/16a4ad88952be742e5b692c75725f60717fa180b

It would be good to have this back ported so that can be one step closer to having support for all content in multiplayer.

Contributor guide

Tech stack
cpp
Domain
backend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
C++Diablo moddingmultiplayer concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
The commit by pionere (16a4ad88952be742e5b692c75725f60717fa180b) needs to be backported to the main branch. The fix involves changes to the Zhar quest logic to work in multiplayer. Study the commit diff and adapt it to the current codebase, ensuring compatibility with existing multiplayer synchronization in DevilutionX. Test the quest in both single and multiplayer modes.