diasurgical/devilutionX

Port fixes for multiplayer dsync from Pioners fork

Open

#2725 opened on Aug 27, 2021

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C++ (7,255 stars) (743 forks)batch import
help wanted

Description

Describe @pionere has a lot of interesting in his port, one of the major parts is some new network update logic to reduce desync

This is mainly done via the following commit: https://github.com/diasurgical/devilutionX/commit/bcbef3afa45e36cbe4fc233ff8261553bf25073e

Porting this is complicated a bit by large part of the fork still using an holder iteration of the code and a different code style, but it should still be reasonably to do so.

Steps

  1. Go over the commit and get a good feel for the semantic changes, and separate it from the style changes.
  2. Start applying the same changes to the code
  3. Run two clients on your local system and run a TCP game where you test multiplayer works as intended
  4. Create a pull request with the backported code

Expected behavior It might be a good idea to also test this on the fork before starting the process to get a good feel for how it works and now to verify it.

Contributor guide

Tech stack
cpp
Domain
backendperformance
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
C++ proficiencyTCP networking knowledgeGame networking concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Review the linked commit (bcbef3a) in @pionere's fork to understand the semantic changes for reducing desync. Separate these from style changes and apply them to the current codebase. Test by running two clients locally in a TCP game to verify multiplayer works as intended.